New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssr): add `experimentalDynamicComponent` aka dynamic imports #5033

Merged

nolanlawson merged 14 commits into master from mob/dynamic-import

Dec 16, 2024

Collaborator

nolanlawson commented Dec 10, 2024 •

edited

Loading

Details

Fixes #5021

Related: #5031 #5032

Does this pull request introduce a breaking change?

😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

🤞 No, it does not introduce an observable change.

wjhsf and others added 5 commits

December 10, 2024 16:14


          fix(ssr): support dynamicImports config

ec8ae40


          test: fix tests

383df68


          fix: add a bunch more todos

bec84eb


          test: add comprehensive tests

b08fc7f


          fix: add todos

219b925

nolanlawson requested a review from a team as a code owner

December 10, 2024 22:31

nolanlawson added 3 commits

December 10, 2024 14:32


          fix: format

320b3bc


          fix: rename

eff7d2e


          fix: types

933d918

nolanlawson changed the title ~~Mob/dynamic import~~ fix(ssr): add experimentalDynamicComponent aka dynamic imports

nolanlawson requested a review from wjhsf

December 11, 2024 00:45


          test: another test

09963c5

wjhsf approved these changes

View reviewed changes

nolanlawson commented

View reviewed changes

packages/@lwc/ssr-compiler/src/__tests__/dynamic-imports.spec.ts Show resolved Hide resolved


          Update packages/@lwc/ssr-compiler/src/__tests__/dynamic-imports.spec.ts

a5e7fd2

nolanlawson commented

View reviewed changes

packages/@lwc/ssr-compiler/src/compile-js/index.ts Show resolved Hide resolved


          Update packages/@lwc/ssr-compiler/src/compile-js/index.ts

7b5edc0

nolanlawson commented

View reviewed changes

packages/@lwc/ssr-compiler/src/compile-js/index.ts Outdated Show resolved Hide resolved


          Update packages/@lwc/ssr-compiler/src/compile-js/index.ts

d4b3d22

nolanlawson commented

View reviewed changes

packages/@lwc/ssr-compiler/src/compile-js/index.ts Show resolved Hide resolved


          Update packages/@lwc/ssr-compiler/src/compile-js/index.ts

171e978

nolanlawson commented

View reviewed changes

packages/@lwc/ssr-compiler/src/compile-js/index.ts Show resolved Hide resolved


          Update packages/@lwc/ssr-compiler/src/compile-js/index.ts

1ca0076

nolanlawson merged commit 5935426 into master

11 checks passed

nolanlawson deleted the mob/dynamic-import branch

December 16, 2024 18:48

cardoso mentioned this pull request

fix(ssr-compiler): namespace & name are optional in CompilerTransformOptions #5058

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet